Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver #6550

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver #6550

merged 1 commit into from
Nov 12, 2019

Conversation

KevinYang21
Copy link
Member

Jira

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Too minor a change to add unit test. Tested locally.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@KevinYang21
Copy link
Member Author

@pingzh @saguziel PTAL

@codecov-io
Copy link

Codecov Report

Merging #6550 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6550      +/-   ##
==========================================
- Coverage   84.07%   84.07%   -0.01%     
==========================================
  Files         639      639              
  Lines       36900    36900              
==========================================
- Hits        31024    31022       -2     
- Misses       5876     5878       +2
Impacted Files Coverage Δ
airflow/www/views.py 76.47% <ø> (ø) ⬆️
airflow/utils/dag_processing.py 58.15% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d25ef2b...544c8c5. Read the comment docs.

@potiuk potiuk merged commit 03a46dd into apache:master Nov 12, 2019
potiuk pushed a commit that referenced this pull request Nov 12, 2019
@KevinYang21 @potiuk
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (#6550)
cc399c5 
(cherry picked from commit 03a46dd)
GnunuX pushed a commit to GnunuX/airflow that referenced this pull request Nov 13, 2019
@KevinYang21
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (apa…
02348dc 
…che#6550)
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
@KevinYang21 @eladkal
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (apa…
45b42a0 
…che#6550)

(cherry picked from commit 03a46dd)
kaxil pushed a commit that referenced this pull request Dec 12, 2019
@KevinYang21 @kaxil
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (#6550)
5d92162 
(cherry picked from commit 03a46dd)
@22quinn
Copy link
Contributor

22quinn commented Aug 4, 2020

@kaxil @potiuk Seems like this commit is not cherry-picked into www_rbac. I got an error when setting pool size to -1 in 1.10.11 rbac webserver. Can we add it in 1.10.12?

https://github.com/apache/airflow/blob/1.10.11/airflow/www_rbac/views.py#L2385

@potiuk potiuk added this to the Airflow 1.10.12 milestone Aug 4, 2020
@potiuk
Copy link
Member

potiuk commented Aug 4, 2020

Marked it for 1.10.12

potiuk added a commit that referenced this pull request Aug 14, 2020
@potiuk
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (#6550)
e77c28f 
This is a follow-up to 5d92162.

The original fix only applied to the www UI not the www_rbac one.

(cherry picked from commit 03a46dd)
kaxil pushed a commit that referenced this pull request Aug 14, 2020
@potiuk @kaxil
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (#6550)
84e52e8 
This is a follow-up to 5d92162.

The original fix only applied to the www UI not the www_rbac one.

(cherry picked from commit 03a46dd)
kaxil pushed a commit that referenced this pull request Aug 15, 2020
@potiuk @kaxil
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (#6550)
f978542 
This is a follow-up to 5d92162.

The original fix only applied to the www UI not the www_rbac one.

(cherry picked from commit 03a46dd)
kaxil pushed a commit that referenced this pull request Aug 15, 2020
@potiuk @kaxil
[AIRFLOW-5897] Allow setting -1 as pool slots value in webserver (#6550)
fb98e25 
This is a follow-up to 5d92162.

The original fix only applied to the www UI not the www_rbac one.

(cherry picked from commit 03a46dd)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@potiuk
Allow setting -1 as pool slots value in webserver (apache#6550)
edcae6e 
This is a follow-up to 5d92162.

The original fix only applied to the www UI not the www_rbac one.

(cherry picked from commit 03a46dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saguziel saguziel saguziel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Airflow 1.10.12
Development

Successfully merging this pull request may close these issues.
5 participants
@KevinYang21 @codecov-io @22quinn @potiuk @saguziel